focus-shift/jollyday

French Subdivision holidays missing descriptions

Closed this issue · 2 comments

More information

Most holidays of subdivisions in France, e.g. the 10th of June in Guyane are missing descriptions.

Hey @XSpielinbox,
I just took a quick look and I would say that not only the descriptions are missing but also the subdivisions are wrong? Should they not be like here, https://de.wikipedia.org/wiki/ISO_3166-2:FR, since 2016?

Auvergne-Rhône-Alpes FR-ARA
Bourgogne-Franche-Comté FR-BFC
Bretagne FR-BRE
Centre-Val de Loire FR-CVL
Grand Est FR-GES
Hauts-de-France FR-HDF
Île-de-France FR-IDF
Normandie FR-NOR
Nouvelle-Aquitaine FR-NAQ
Okzitanien FR-OCC
Pays de la Loire FR-PDL
Provence-Alpes-Côte d’Azur FR-PAC

And also the Départements are no longer written with numbers.

And

<Fixed month="NOVEMBER" day="11" descriptionPropertiesKey="REMEMBRANCE"/>

should be named Armistice 1918.

So, there are definitely many subdivisions missing, but based on https://www.iso.org/obp/ui/#iso:code:3166:FR the codes still seem valid to me.

Also e.g. Grand Est (FS-GES) seems to be correct already. But I would say that e.g. Moselle should not be a subdevision of Grand Est, making it a Sub-Subdevision, but that it should be independent: FR-57, if I am not mistaken.

As for the naming of November I am unsure. https://en.wikipedia.org/wiki/Public_holidays_in_France would support your statement.