couple question

Question

couple question

GrosSacASac opened this issue 7 years ago · 6 comments

GrosSacASac commented 7 years ago

First of all, thank you.

A couple questions; Is it possible to add <summary>/<details> ? What about hidden html attribute ?

GrosSacASac commented 7 years ago

PR sent !

Answer 1 · 2017-11-27T15:00:50.000Z

@GrosSacASac Happy to add whatever makes the library more accurate!

Can you please provide some more details? Why <details> — that doesn't seem tabbable normally? <summary> does, though, at least in Chrome. Let's make sure it's the same cross-browser.

How you tried the hidden attribute, and it's not treated correctly? I just tried it in a demo and didn't notice any problem: the hidden element was skipped as expected.

Answer 2 · 2017-11-27T15:10:53.000Z

Yes <summary> does.

test summary

Full paragraph below summary

<details>
   <summary>test summary</summary>
   <p>Full paragraph below summary</p>
</details>

Yes I tried it works, my bad.

Answer 3 · 2017-11-28T20:16:53.000Z

<audio controls> and <video>

Answer 4 · 2017-11-29T00:47:07.000Z

Sure, @GrosSacASac: open to a PR adding any fancy new elements that are tabbable!

Answer 5 · 2018-02-03T22:48:14.000Z

For anybody who comes along this issue and wants to help: the PR #21 was closed but not completed. PRs still welcome if anybody would like to add elements.