fogleman/Craft

deps/glfw/examples/ could be removed from the code?

crazyBaboon opened this issue · 3 comments

It is an example folder, so I think it is doing nothing there.

I'll reply since nobody else did. Yes, see my commits for reference: 54f4d97 and 2c12ba7.

It could be removed. I always cmake with -DGLFW_BUILD_EXAMPLES=0 to reduce build time.

@mpaoloni am I wrong or you have never contributed your changes? https://github.com/fogleman/Craft/pulls?q=is%3Apr+author%3Ampaoloni