A package for the Arch User Repository (AUR).

Question

A package for the Arch User Repository (AUR).

Aniket-Pradhan opened this issue 5 years ago · 20 comments

Aniket-Pradhan commented 5 years ago

Hello there.

Kudos for such an amazing project.

I was wondering if you were interested in making an AUR package for it? I can help, if you want to. 😄

Answer 1 · 2019-03-09T22:18:59.000Z

Since @fogleman seems to be sleeping (no offense), maybe either you or I could create the package 😄.

I am on Manjaro v18.0 (based on Arch Linux) but I have no experience in this since I am primarily a Windows person.

Answer 2 · 2019-03-10T07:32:40.000Z

I don't think he is sleeping 😛

I would upload a basic skeleton on my fork, and we both can work on it.

We would need to patch the program a bit (or just create a wrapper script) so that we can execute the script from anywhere in the system. Currently, we can only execute Craft from it's base directory only.

Answer 3 · 2019-03-10T08:41:21.000Z

Here, you can find the PKGBUILD and the launcher.

A few tweaks are remaining.
Mainly:

Running craft normally does not store in the databases, because you need sudo access for it (everything is in /opt)
Update dependencies. I was too lazy to update them in the PKGBUILD.

If you want to contribute, you can help here. Or, find out an issue yourself (I don't think the PKGBUILD is fully clean, yet). I will be uploading it to the AUR soon.

Answer 4 · 2019-03-10T12:29:59.000Z

Wow, nice work. And I just finished my PKGBUILD, right here:

# Maintainer: Kied Llaentenn (@kiedtl)

pkgname=craft
pkgdesc="A simple Minecraft clone written in C using modern OpenGL (shaders)."
pkgver=1.0
pkgrel=1
arch=('x86_64')
url=https://github.com/fogleman/Craft
license=('MIT')
provides=('craft')
makedepends=('cmake')
source=("craft-$CARCH-v${pkgver}.tar.gz::https://github.com/fogleman/Craft/archive/v${pkgver}.tar.gz")
sha512sums=('SKIP')

build() {
    cd "Craft-${pkgver}"
    cmake .
    make
}

package() {
    cd "$srcdir/$_distdir"
    cd "Craft-${pkgver}"
    mv ./craft $pkgdir
}

I guess we can just go with yours since you obviously have more experience.

We would need to patch the program a bit (or just create a wrapper script) so that we can execute the script from anywhere in the system. Currently, we can only execute Craft from it's base directory only.

And as you can see I completely forgot about his issue.
BTW can you give me collaborator access to your repo? I'll work on the dependency issue as soon as I get a chance.

Answer 5 · 2019-03-10T12:41:43.000Z

BTW something might be wrong with the pkgbuild, when I ran makepkg it errored:

# snip....
Scanning dependencies of target windows
[ 98%] Building C object deps/glfw/tests/CMakeFiles/windows.dir/windows.c.o
[100%] Linking C executable windows
[100%] Built target windows
==> Entering fakeroot environment...
==> Starting package()...
chown: cannot access '/opt/craft': No such file or directory
==> ERROR: A failure occurred in package().
    Aborting...
➜  craft-git git:(master) ✗

Answer 6 · 2019-03-10T13:00:57.000Z

BTW can you give me collaborator access to your repo? I'll work on the dependency issue as soon as I get a chance.

Done!

BTW something might be wrong with the pkgbuild, when I ran makepkg it errored:

Lemme check.

Answer 7 · 2019-03-10T13:07:15.000Z

And, fixed the issue. :)

Answer 8 · 2019-03-10T20:42:23.000Z

Quick question: I was wondering if the dependencies mentioned in the README are makedepends or depends.

Answer 9 · 2019-03-10T21:39:10.000Z

FYI I was able to build the package successfully,

Answer 10 · 2019-03-11T04:33:47.000Z

FYI I was able to build the package successfully,

Cool!

The mentioned dependencies should be in depends. The only makedepends I can think of is make and cmake.

Answer 11 · 2019-03-11T11:17:28.000Z

The only makedepends I can think of is make and cmake.

I don't think make should be explicitly added; according to the Arch wiki, those of the group base-devel can be implicitly used without being listed as a dependency.

Answer 12 · 2019-03-11T14:57:52.000Z

OK, I think most of the issues are resolved, can we upload it to the AUR now?

Answer 13 · 2019-03-11T15:32:34.000Z

I don't think make should be explicitly added; according to the Arch wiki, those of the group base-devel can be implicitly used without being listed as a dependency.

Correct!! I was looking for make in the base group... 😛

Yes! I will be pushing it to the AUR. I'll add you as a co-maintainer! 😄

Answer 14 · 2019-03-11T15:54:22.000Z

Yes! I will be pushing it to the AUR. I'll add you as a co-maintainer! 😄

Thanks! 😀

Answer 15 · 2019-03-11T15:57:53.000Z

What will you be adding it as? I mean the name of the package?

Answer 16 · 2019-03-11T16:07:23.000Z

Name > craft-git
Because we are building directly from the git repository.

I also need your AUR username...

Answer 17 · 2019-03-11T16:14:40.000Z

my AUR username is kiedtl.

Answer 18 · 2019-03-11T16:16:52.000Z

Can't you two send mails in private？

…

在 2019年3月12日，上午12:14，Kiëd Llaentenn ***@***.***> 写道： my AUR username is kiedtl. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 19 · 2019-03-11T16:17:41.000Z

Haha, yes we can.

Answer 20 · 2019-03-11T16:17:54.000Z

Added! 🎉

I will close this issue. If there's anything, you can always ping me (via mail). ^>^