custom negotiated eParcel charge codes should be allowed

Question

custom negotiated eParcel charge codes should be allowed

jonpday opened this issue 10 years ago · 12 comments

some customers have unique charge costs for eParcel that are not included in Fontis_Australia_Helper_Eparcel::$chargeCodes. Options to fix this are either (a) add a System Config value for "allow custom charge code" which isValidChargeCode will check if charge code is not found in the private array, or (b) use config XML rather than a private array. Option (b) this would allow developers to specify charge codes in their own module's config.xml to validate the codes uploaded by administrators are still valid.

Answer 1 · 2014-10-04T05:48:42.000Z

ping @jonathan-dh

Answer 2 · 2014-10-07T04:11:50.000Z

Hi @jonpday,

I'm absolutely flat out the next few days but will try to have a look asap. PRs welcome if you want.

Answer 3 · 2014-10-07T04:13:03.000Z

no problem @jonathan-dh I did implement option (a) for a short term fix, option (b) might be nice when there's more time (hah!)

Answer 4 · 2014-10-07T05:30:53.000Z

Would it worthwhile adding a system config option to specify additional codes, instead of in an XML file? This way you wouldn't need a developer to dive in and modify a file if Australia Post hand out one of these custom codes, while still allowing for validation against a defined list.

Answer 5 · 2014-10-07T05:55:56.000Z

yeah, that makes sense @chnorton I'll change it so that there is one system config field for "allow any charge code" and another (comma-separated) for "allow the following additional charge codes"

Answer 6 · 2015-01-02T05:46:42.000Z

Hi @jonpday, happy new year!

Sorry I never got around to this, the end of 2014 was hectic. Did you get it working? Any chance you could open a PR? I doubt I'm going to dive into this any time soon unfortunately :(

Answer 7 · 2015-01-05T11:01:32.000Z

hiya, we just went with the lightweight solution (aligent@7a48be6) in the end, might revisit if the client needs further changes... happy to PR that if you'd like?

Answer 8 · 2015-01-06T00:06:32.000Z

I think that would be enough for most users. @chnorton, what do you think?

Answer 9 · 2015-01-16T01:21:54.000Z

Happy to accept a PR for this - the lightweight solution looks fine to me.

Answer 10 · 2015-06-04T01:46:50.000Z

Added to 2.6.0 and 3.1.0 versions.

Answer 11 · 2015-10-26T05:24:57.000Z

This throws an error now if the Charge code is one of the standard codes.

$isStandard = in_array($chargeCode, $this->standardChargeCodes);

        if ($isStandard) {
            return true;
        }
        elseif (!$isStandard && Mage::getStoreConfigFlag('doghouse_eparcelexport/charge_codes/allow_custom_charge_codes')) {

The code needs to return true if $isStandard

Regards
Geoff

Answer 12 · 2015-10-27T05:16:53.000Z

that makes sense @behindthepage - given that this issue has been closed, suggest that you raise a new issue and create a merge request with the change you've sketched then @chnorton can review and incorporate it.