foo-software/lighthouse-check

PWA check returns wrong value

Closed this issue · 4 comments

Our website does not use PWA but the Lighthouse score always returns 42. I don't know if 42 is an easter egg ;) but I would prefer a 0 or n. a. My implementation looks like this (in the jobs section):

lighthouse-check-desktop:
    runs-on: ubuntu-latest
    if: ${{ always() }}
    needs: [safari-job, chrome-job, firefox-job]
    steps:
      - uses: actions/checkout@master
      - run: mkdir /tmp/artifacts
      - name: Run Lighthouse Desktop
        uses: foo-software/lighthouse-check-action@master
        id: lighthouseCheck
        with:
          device: "desktop"
          maxRetries: 3
          gitAuthor: ${{ github.actor }}
          gitBranch: ${{ github.ref }}
          outputDirectory: /tmp/artifacts
          urls: ${{ secrets.STAGE_URL }}
          sha: ${{ github.sha }}
          slackWebhookUrl: ${{ secrets.SLACK_WEBHOOK }}

Bildschirmfoto 2021-11-12 um 09 29 03

This project is not intended to change the functionality of Lighthouse. It provides extra utilities around running Lighthouse and options for handling results. To learn more about the PWA metric, I would recommend reading this article.

Hi @adamhenson, I thought so. Have you ever experienced something like that on the API. Running litehouse in chrome shows the correct score.

Hi @amokato - sorry, I misunderstood the issue. I’m re-opening until we get to the bottom of it. That score should be the same between running from Chrome and Lighthouse programmatically (and in this GitHub Action which runs Lighthouse programmatically).

Two questions:

  • Are you targeting the same device when comparing between the browser and the GitHub Action? (the GitHub Action targets mobile by default)
  • Which version of Lighthouse are you running in the browser?
stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.