Funniest bug ever

Describe the bug
Unable to publish

To Reproduce

Click on preview, and save disppear when hovering trying hover on it

Expected behavior

Ability to publish

Screenshots

funny.mp4

Desktop (please complete the following information):

OS, version: MacOS Sonoma 14.0
Browser, version: Thorium 116 and Safari 17

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@eznix86 I will have to test this on my mac my self as well, but before I do I did want to ask is it doing it in any other browser as well? And what happens when you refresh the page and clear cache ect?

@eznix86 I will have to test this on my mac my self as well, but before I do I did want to ask is it doing it in any other browser as well? And what happens when you refresh the page and clear cache ect?

Let me give you a list where it does not work:

Google Chrome Version 121.0.6167.184 (Official Build) (x86_64)
Thorium Version 116.0.5845.169 (Official Build) (x86_64)
Firefox 123.0 (64-bit)
Floorp Browser 11.8.1 (64-bit)
Brave Browser Version 1.57.57 Chromium: 116.0.5845.163 (Official Build) (×86_64)

Where it does work:

Sigma OS Version 1.14.0 (1.14.0.9-wv)

For a clear cache, same. Also I tried on other browsers. So I guess it's a UI issue.

What is weird is that on the Sigma OS browser it works. But I hope this list can help you figure out the issue.

Another note also; I have zero problems on the console. Try to see the hover mechanism.

@eznix86 Awesome I will check it out on my end as well, then and see if I may be able to figure it out.

Here's the issue

https://github.com/forem/forem/blob/main/app/javascript/article-form/components/EditorActions.jsx#L67-L67

Here's the issue

https://github.com/forem/forem/blob/main/app/javascript/article-form/components/EditorActions.jsx#L67-L67

Did you manage to reproduce it ?

Yes, mousing over the bottom bar triggers the switchHelpContext function, which in turn sets the state to the commonProps which has the preview set to false.

forem/app/javascript/article-form/articleForm.jsx

Lines 411 to 419 in f263e17

    
           switchHelpContext = (event, override = null) => { 
        
             const id = override || event.target.id; 
        
             this.setState({ 
        
               ...this.setCommonProps({ 
        
                 helpFor: id, 
        
                 helpPosition: event.target.getBoundingClientRect().y, 
        
               }), 
        
             }); 
        
           };

forem/app/javascript/article-form/articleForm.jsx

Lines 191 to 203 in f263e17

    
           setCommonProps = ({ 
        
             previewShowing = false, 
        
             previewLoading = false, 
        
             helpFor = null, 
        
             helpPosition = null, 
        
           }) => { 
        
             return { 
        
               previewShowing, 
        
               previewLoading, 
        
               helpFor, 
        
               helpPosition, 
        
             }; 
        
           };

to fix it you need to pass in the current previewShowing state or prevent switchHelpContext from triggering if the preview is open.

	switchHelpContext = (event, override = null) => {
	const id = override \|\| event.target.id;
	this.setState({
	...this.setCommonProps({
	helpFor: id,
	helpPosition: event.target.getBoundingClientRect().y,
	}),
	});
	};

	setCommonProps = ({
	previewShowing = false,
	previewLoading = false,
	helpFor = null,
	helpPosition = null,
	}) => {
	return {
	previewShowing,
	previewLoading,
	helpFor,
	helpPosition,
	};
	};