Allow closable divs to persist "close state" via optional "dismissal sku" (Client-side to start)
Closed this issue · 1 comments
Is this feature related to a problem? Please describe.
Some billboards are dismissible (with other locations which could be dismissible in future). However with billboards we do not persist dismissing — which is potentially okay for signed out contexts but is generally not acceptable for signed in where we don't want to keep showing someone the same message in general.
Describe the solution you’d like
The billboard should be dismissible via client-side storage similar to how we traditionally did the "campaign hero"
Admins should be able to define a "dismissal sku" which can hypothetically be applied to any billboard or variation across multiple placements.
We should eventually create user-based database memory of dismissals, but the MVP is client-side, as this can immediately apply to all contexts and is something which has worked for us as an existing pattern — though has scalability issues.
Definition of Done
- Add dismissal sku to billboards
- Allow dismissable billboards to use the sku on client side.
Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.
To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.
If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.
To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.
For full info on how to contribute, please check out our contributors guide.