formapro/pvm

There seems to be a logic error here

bllex opened this issue · 0 comments

bllex commented

$ormToken = $this->objectManager->getRepository($this->tokenClass)->findOneBy([
'id' => $id,
]);
if (false == $ormToken) {
throw new \LogicException(sprintf('The token with id "%s" could not be found', $id));
}
/** @var \Formapro\Pvm\Doctrine\Process $ormProcess */
$ormProcess = $this->objectManager->getRepository($this->processClass)->findOneBy([
'id' => $ormToken->getProcessId(),
]);
if (false == $ormToken) {
throw new \LogicException(sprintf('The process with id "%s" could not be found', $ormToken->getProcessId()));
}

It seems that both $ormToken is being verified on lines 132 and 141, but it seems that $ormProcess is more logical on line 141.