fornwall/rust-static-builder

Unnecessarily dangerous -DOPENSSL_NO_SECURE_MEMORY

brainstorm opened this issue · 4 comments

brainstorm commented

Please see the following for a docker container that does not require that feature to be disabled on OpenSSL 1.1.1g:

https://github.com/brainstorm/rust-htslib/blob/musl_support/docker/Dockerfile.musl

brainstorm commented

... and while I'm here, could you add bzip2 to your great rust-static-builder mix too, pleease? It just takes a:

RUN git clone git://sourceware.org/git/bzip2 \
    && cd bzip2 \
    && make PREFIX=/usr/local/musl bzip2 \
    && make install

:)

  • 👍1
fornwall commented

Thanks! I've added bzip2 now, need to look into https://github.com/GregorR/musl-cross for to avoid -DOPENSSL_NO_SECURE_MEMORY.

brainstorm commented

Thanks! You should perhaps also add it on the README? Also, I believe that my container referred above already avoids having to define that flag? IIRC, upgrading to MUSL 1.2.0 did the trick for me when compiling OpenSSL 1.1.1f.

  • 👍1
fornwall commented

Thanks, added it to the README in 96fa10d