fortedigital/EpiResponsivePicture

Obsolete methods in UrlBuilderExtensions are error prone

Opened this issue · 0 comments

In UrlBuilderExtensions class defined in UrlBuilderExtensionsObsolete.cs file there are methods marked as [Obsolete] but the result when upgrading from old package version is counter productive.

My project might be using Width or Height method and I will get no error after upgrade (only deprecation warning). However UrlBuilder will return query with parameters which are not supported by default ImageSharp:

w instead of width
h instead of height

So it looks like it's better to remove these methods completely or fix them where possible to match with ImageSharp supported query parameters