fortran-lang/stdlib

Replace `make_directory` with `file(MAKE_DIRECTORY <directories>...)`

jfdev001 opened this issue · 1 comments

jfdev001 commented

Per https://cmake.org/cmake/help/latest/command/make_directory.html, the command

make_directory

is deprecated since cmake 3.0 and file(MAKE_DIRECTORY <directories>...) should be used instead (see https://cmake.org/cmake/help/latest/command/file.html#make-directory).

make_directory is used in the following files:

stdlib/src/CMakeLists.txt

Line 148 in 4ebe266

make_directory("${LIB_MOD_DIR}")

stdlib/config/cmake/Findtest-drive.cmake

Line 126 in 4ebe266

make_directory("${${_pkg}_BINARY_DIR}/include")

stdlib/config/cmake/Findtest-drive.cmake

Line 150 in 4ebe266

make_directory("${${_pkg}_BINARY_DIR}/include")

Since the cmake minimum version for the project is 3.14 anyways, I think it would make sense to use the recommended method (i.e., file(MAKE_DIRECTORY)) of creating directories. If this change makes sense, I can go ahead and open PR to make the necessary substitution.

jalvesz commented

Sounds about right! I would be in favor of this update.