forwardemail/nodejs-dns-over-https-tangerine

[feat] Add typescript support

Closed this issue · 4 comments

nikelborm commented

Describe the feature

Hi! I like the library very much and I'm open to cover it with typescript type definitions (and help maintaining those types in the future), so it will have great auto-completion in IDEs and also it will improve documentation along the way.

Are you open for accepting this contribution?

titanism commented

PR is welcome

  • 👍1
nikelborm commented

Ok, I'll create a PR soon

titanism commented

@nikelborm it would also be great for us to get tests working again, not sure if you can help with that 😅

also see v1.5.5 we just released which fixed some core bugs and allowed us to upgrade to latest version of undici

https://github.com/forwardemail/nodejs-dns-over-https-tangerine/releases/tag/v1.5.5

titanism commented

PR welcome