foundry-rs/foundry

feat(wallets): reuse `session_id` across multiple `TrezorSigner`

joshieDo opened this issue · 4 comments

Component

Forge

Describe the feature you would like

pub async fn trezors(&self) -> Result<Option<Vec<WalletSigner>>> {
if self.trezor {
create_hw_wallets!(self, utils::create_trezor_signer, wallets);
return Ok(Some(wallets));
}
Ok(None)
}

Currently, every new instance of TrezorSigner is created with their own session_id. If a passphrase is enabled on the device, it means requesting it for every mnemonic index.

Ideally, each TrezorSigner reuses the first created session_id.

Additional context

No response

May I be assigned to this?

Could I take on this issue?

Hello @joshieDo
can i take this issue
I can modify the function to cache and reuse a single session ID.

I'd be happy to do this.