foundry-vtt-community/macros

remove pf2e macros

Drental opened this issue · 5 comments

Drental commented

The pf2e macros are outdated and breaking newer people's characters. Can you please remove them?

The system evolves faster than the macros can and the number of macros in this module is too large to be picked up by any developer who has good system knowledge.

this is causing us supporters frustration because the support cases are entirely preventable and the users have a bad first experience with FVTT that they really don't need. Thank you in advance.

AnthonyVadala commented

Hey Drental, I believe you are correct that the majority of pf2e macros should be removed due to lack of updates. When Foundry version 10 is released, all macros will be re-evaluated for version compatibility and those that are not likely to be supported or have been merged into the game system will be removed similar to what happened when version 9 was released.

You can see current version 9 compatibility here.

Drental commented

then to adress the ones that are actively damaging actors and can only be fixed by exporting and json surgery (as we like to call it)

any macro that contains "customModifiers" (or "addCustomModifier") is actively harmful, can you grep and remove those? If you give me the list I can make sure that all of them are already replaced by the system if that helps your peace of mind.

The short list I notice at a glance are:

  • animal Rage
  • Dueling Cape
  • Dueling Parry
  • fury instinct rage
  • gozreh Sickness
  • inspire Courage
  • parry
  • premonition of avoidance
  • rain of embers stance
  • terrifying resistance
  • probably more, but I went off from a glance at the names and a short check inside the suspicious ones.

Thank you!

Drental commented

(all of these are of course already automated by the system)

jocolamarco commented

"(...) will be removed similar to what happened when version 9 was released" - @AnthonyVadala please refer to the ones above which weren't removed.
I've had issues with this (and raised a few tickets) and I've seen plenty of other people with corrupted actors due to using some macros.

AnthonyVadala commented

@Drental @jocolamarco sorry for the delayed response, every nonworking and broken macro from every system have now been removed from their respective system compendium and placed in a new directory called archived as of update v9.13

All current open issues have also been re-tagged and a new pinned issue has been created to track all user reported macro issues outside of the GitHub project board.

  • ❤️1