foundryvtt/dnd5e

Redesign Advancement applications using ApplicationV2 & V2 styles

Opened this issue · 5 comments

arbron commented
  • Advancement Manager (#4765)
  • Advancement Config
    • AbilityScoreImprovementConfig (#4766)
    • HitPointsConfig (#4709)
    • ItemChoiceConfig (#4736)
    • ItemGrantConfig (#4722)
    • ScaleValueConfig (#4767)
    • SizeConfig (#4768)
    • TraitConfig (#4769)
  • Advancement Flow
    • AbilityScoreImprovementFlow
    • HitPointsFlow
    • ItemChoiceFlow
    • ItemGrantFlow
    • ScaleValueFlow
    • SizeFlow
    • SubclassFlow
    • TraitFlow
  • AdvancementMigrationDialog
JPMeehan commented

Bugfix request as part of this - Handlebars and textareas are tricky, could the whitespace please be fixed for the hints? I believe {{~> 'my-partial}} for partials and {{~value~}} for value references would help resolve the tab/indentation issues.

arbron commented

Bugfix request as part of this - Handlebars and textareas are tricky, could the whitespace please be fixed for the hints? I believe {{~> 'my-partial}} for partials and {{~value~}} for value references would help resolve the tab/indentation issues.

Is that actually an issue anywhere in the system? All our usage of <textarea> have no extra space (e.g. <textarea>{{ var }}</textarea>, so if any weird spacing is occurring it isn't from the system.

JPMeehan commented

The hint field entry for advancements

arbron commented

The hint field entry for advancements

Again, no space there:

<textarea name="hint" {{~#if default.hint}} placeholder="{{ default.hint }}"{{/if}}>{{ hint }}</textarea>
JPMeehan commented

The issue is if the value has spaces, e.g. I copy from a PDF with line breaks. I'm on mobile but it's easy to reproduce