Variables defined 3 times with differrent values

[God-of-platypus]

Hello,

While looking through the code I found out that the macro BC_VOLTAGE_MAX_MSL_mV is defined in 3 files: panasonic_ncr18650bd.h, lg_inr18650mj1.h and battery_cell_cfg.h.
That macro has different values according to which files it has been defined in. It takes two values: 4200 or 2800.

Which one should I use ?

[God-of-platypus]

Update: I have checked for RSL and MOL. They have the same issue

[foxBMS]

Dear @God-of-platypus,

the file battery_cell_cfg.h is used during the build. The other files in the opt directory are not used (you can see that if you search for the file name in the repository).
You have to define the values accordingly to the used cell in battery_cell_cfg.h.

Best regards,
The foxBMS Team