foxglove/mcap

mcap cli merge does not copy metadata / attachments

mckay6842 opened this issue · 4 comments

mckay6842 commented

Description
When merging two mcap files via the cli, the output mcap file does not contain metadata records that were present in the input files.

  • Version: go/mcap/v1.0.1
  • Platform: Linux

Steps To Reproduce

# starting with two mcap files test.mcap and test2.mcap (both containing no metadata)

> mcap info test.mcap | grep metadata
metadata: 0
> mcap info test2.mcap | grep metadata
metadata: 0

# add metadata to one of the files
> mcap add metadata --name "test" --key "key=value" test.mcap

# check if metadata is now present
> mcap info test.mcap | grep metadata
metadata: 1
> mcap get metadata --name "test" test.mcap                  
{
  "key": "value"
}

# merge the two files
> mcap merge test.mcap test2.mcap -o merged.mcap

# check the output file
> mcap info merged.mcap | grep metadata                                                                                                                                  1 
metadata: 0
> mcap get metadata --name "test" merged.mcap 
failed to fetch metadata: metadata test does not exist

Expected Behavior
metadata (and attachments) should be copied as well

foxhubber commented

Internal tracking ticket: FG-4490

achim-k commented

Attachments are also not copied, adapted the title

defunctzombie commented

Attachments should also be included now.