fpco/stackage-curator

github markup eating `<` in checklists

juhp opened this issue · 14 comments

juhp commented

This is really a github markup rendering regression (I opened a support ticket now).
See also mojombo/github-flavored-markdown#60.
Basically in checklists < seems to now trigger href link rendering.

- [ ] here is a checklist with < words than expected

becomes

  • here is a checklist with < text shown than expected

Currently I add backquotes around < in stackage-curator check output by hand,
but I thought it might be good to add such a workaround to stackage-curator.
I don't know yet if there is a better/simpler way to quote <.

Let's experiment:

  • here is a checklist with < words than expected
  • here is a checklist with < words than expected

Source:

* [ ] here is a checklist with &lt; words than expected
* [ ] here is a checklist with \< words than expected

Wow, that bug is really bad. Let's try something a bit weirder:

  • here is a checklist with < words than expected
* [ ] here is a checklist with &#60; words than expected
juhp commented

Yeah, pretty bad...

juhp commented
more > or less < than
- more > or less < than
- [ ] more > or less < than

<stackage.org>
<http://stackage.org>

more > or less < than

  • more > or less < than
  • more > or less < than

<stackage.org>
http://stackage.org

And one more:

This is &lt; double escaped

This is &amp;lt; double escaped

Oh well :/

Alright, I've pushed a commit that adds a workaround as you suggested. Let's hope it works :)

juhp commented

Thanks!

juhp commented

I tried it here locally and it seems to work. :-)

juhp commented

some-new-version is out of bounds for:

  • some-older-package-version (> 1 && < 2). Author Maintainer <dev@example.com> @somenewversiondeveloper

It even quotes the email address too. :)

juhp commented

Anyway if there is some update on the github support ticket I will follow up here.

juhp commented

Github have acknowledged the regression and say they are working on a fix.

juhp commented

Okay this has now been fixed by GitHub - so I think the change can be reverted now but it was good to have it in the interim anyway. :)

Awesome :) I've just pushed a revert.