fralalonde/dipstick

Upgrade to Rust 2018 edition

fralalonde opened this issue · 5 comments

fralalonde commented
Upgrade to Rust 2018 edition
Atul9 commented

@fralalonde I would like to work on this.

  • 👍1
fralalonde commented

Be my guest! I'm not sure how much work this entails, feel free to make a single PR or multiple smaller ones.

Atul9 commented

@fralalonde I have opened up a PR - #54, please check.

fralalonde commented

Reopening this as the last merged changes broke different parts of the make build (examples, benchmarks, docs) and left many warnings unfixed, such as

warning: unused extern crate
  --> src/lib.rs:31:1
   |
30 | / #[cfg(feature = "parking_lot")]
31 | | extern crate parking_lot;
fralalonde commented

It seems cargo fix --edition only does the easy stuff and leaves much to do.