fralalonde/dipstick

Fails to compile under newest nightly

vorner opened this issue · 1 comments

Hello

When trying to compile with today's nightly ($ rustc --version rustc 1.36.0-nightly (d35181ad8 2019-05-20)), the compilation fails with:

error[E0283]: type annotations required: cannot resolve `std::string::String: std::convert::AsRef<_>`
   --> src/output/prometheus.rs:150:41
    |
150 |         match minreq::get(self.push_url.as_ref())
    |     

AFAIK this „needs to be more specific“ errors are actually allowed breakage/acceptable exception to the stability promise ☹. So I'm not sure if it's worth reporting to rustc (I'll try it anyway, but it might be worth to add some annotations in dipstick too, just in case).

Ah, seems to be this rust-lang/rust#60958