Review lab1
rogierz opened this issue · 0 comments
rogierz commented
Review by Ruggero Nocera
Major
- The state is an array of actions, but when the code needs to compute the priority function it transforms the state into a set of covered numbers. Maybe a state that keeps track of both the last action and the covered numbers could improve the time needed by the algorithm.
Minor
- In
priority_function_astar*
functions, why do you uselen(range(N))
instead ofN
?
Final thoughts
The code is a really nice implementation of A*. I think that one of the strengths of your solution is how you generate the candidate "blocks" to add to the current state. In addition, I really appreciated how detailed is your report and how deeply tested your solution is.