[MenuIcons] Stripping ... in German locale doesn't work any more

[bege10]

I have created icons for the German locale. There the menu entries with "..." have a blank between the text and the "...", e.g. "Speichern unter ..." ("Save as...").
Therefore I have named the respective files with a blank at the end (Speichern unter .ico). That worked well for a long time. Now it doesn't any more.
I see that it still works for the provided files for English locale which don't have this blank.

I restored MenuIcons v1.2.2 and it still does not work.
So maybe it is related to the update of NPP from v7 to v8?

[francostellari]

I understand your issue. In the future I will consider moving the images into a en-us folder.

[bege10]

Thank you for your answer, this seems to be related to the other issue I created.
Do you have an idea for a solution for this issue?

[francostellari]

Please test the new version 1.24 of MenuIcons. The icon folder has been localized to EN-US.

[bege10]

Thank you. I will be out of town until beginning of September and will test the new version when I am back home.

[bege10]

Please, read my first post again. This issue is different from #9, it is not about the localized folder but about "Menu item to file name mapping".
The second option "Plain text match (strip '&' and '...') does not work with German locale with menu items that contain '...'.

[francostellari]

I'm sorry I misunderstood your problem. https://github.com/francostellari/NppPlugins/blob/main/MenuIcons/MenuIcons_dll_1v25_x64.zip Can you please use this version of the plugin and try the "Generate list" button in the Options dialog box. It should open a file with a list of the menu items and the filename of the icon that the plugin is looking for. Can you check the name correspondence? Regards, Franco

…

On Sun, Sep 19, 2021 at 1:07 PM bege10 ***@***.***> wrote: Please, read my first post again. This issue is different from #9 <#9>, it is not about the localized folder but about "Menu item to file name mapping". The second option "Plain text match (strip '&' and '...') does not work with German locale with menu items that contain '...'. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL5TXITZKP2M5X4KBZ7WGF3UCYKGFANCNFSM5BKMS6AA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Franco

[bege10]

Here are two examples:

MenuIcons.txt: &Öffnen ? 41002 ==> C:\Program Files\Notepad++\Plugins\MenuIcons\DE\Datei\Öffnen ?.ico
&Drucken ? 41010 ==> C:\Program Files\Notepad++\Plugins\MenuIcons\DE\Datei\Drucken ?.ico

In MenuIcons.txt there is a "?" at the place of the "...", which I think is wrong because adding it to the file name does not help.

Maybe related but different issues:

• The menu item names don't show the underlined letter marked with "&" in MenuIcons.txt.
• Do you know why most icons vanish after a few actions in Notepad++?

[francostellari]

I think I found the issue. In the German translation the "..." is actually one unicode character instead of 3 dots. Somehow it would get transformed into a "?" I have updated v1.25 at https://github.com/francostellari/NppPlugins/blob/main/MenuIcons/MenuIcons_dll_1v25_x64.zip Please, test it out again when you have time. I'm also removing the space in this version. Refer to the generated list to check what the expected filename is for your given setup and options. Regarding: - The menu item names don't show the underlined letter marked with "&" in MenuIcons.txt. It's a Windows feature... you need to press "Alt" to show the underline. Regarding: - Do you know why most icons vanish after a few actions in Notepad++? Unfortunately it's a known issue related to the use of an older menu update function in N++ code. Last time it was discussed, it is related to a change to the recent file list... that triggers some menu updates... that erase the icons. At the time (several years ago) we submitted a fix but did not get into the code... I think I have a solution that does not require N++ code changes but it requires a complete rewrite of the plugin and I have not had time to do it. I hope this fixes your problem. Regards, Franco

…

On Tue, Sep 21, 2021 at 3:06 PM bege10 ***@***.***> wrote: Here are two examples: MenuIcons.txt: &Öffnen ? 41002 ==> C:\Program Files\Notepad++\Plugins\MenuIcons\DE\Datei\Öffnen ?.ico &Drucken ? 41010 ==> C:\Program Files\Notepad++\Plugins\MenuIcons\DE\Datei\Drucken ?.ico [image: Screenshot_278] <https://user-images.githubusercontent.com/1184237/134231198-ebbc3d23-7a85-4b52-a70f-cd12248c1e6c.png> In MenuIcons.txt there is a "?" at the place of the "...", which I think is wrong because adding it to the file name does not help. Maybe related but different issues: - The menu item names don't show the underlined letter marked with "&" in MenuIcons.txt. - Do you know why most icons vanish after a few actions in Notepad++? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL5TXITYHT3C75QA3MVKCTDUDDJTZANCNFSM5BKMS6AA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Franco

[bege10]

Thank you very much! The icons are back.
Now I understand why it even did not work with older MenuIcons versions: They must have changed the "..." in the German locale together with the wording of several menu items with a Notepad++ update some time ago.

BTW: Why don't you use the option "Command ID match" for the icons that come with the plugin? Wouldn't that work with any locale and prevent problems with such changes in the wording of menu items?

[bege10]

Regarding: - Do you know why most icons vanish after a few actions in Notepad++?
Unfortunately it's a known issue related to the use of an older menu update function in N++ code. Last time it was discussed, it is related to a change to the recent file list... that triggers some menu updates... that erase the icons.

There are more actions than this: Open file from workspace window (sometimes) and open configuration file of any plugin from within the plugins menu.
So maybe the trigger is to open any file from within NPP.

[francostellari]

The trigger is related to a menu change by NPP due to a user action. Opening/closing a file will probably alter the recent file list as well.

…

On Sat, Sep 25, 2021 at 4:00 PM bege10 ***@***.***> wrote: Regarding: - Do you know why most icons vanish after a few actions in Notepad++? Unfortunately it's a known issue related to the use of an older menu update function in N++ code. Last time it was discussed, it is related to a change to the recent file list... that triggers some menu updates... that erase the icons. There are more actions than this: Open file from workspace window (sometimes) and open configuration file of any plugin from within the plugins menu. So maybe the trigger is to open any file from within NPP. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL5TXIVM2LQ7Z6JVCLZ4CRTUDYS4FANCNFSM5BKMS6AA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Franco

[bege10]

The trigger is related to a menu change by NPP due to a user action. Opening/closing a file will probably alter the recent file list as well.

You are right, it does alter the file list.

Did you see this question above?

BTW: Why don't you use the option "Command ID match" for the icons that come with the plugin? Wouldn't that work with any locale and prevent problems with such changes in the wording of menu items?

[francostellari]

I believe the crash issue was resolved in the latest version 1v25.

[bege10]

There was no crash but the icons simply were not displayed. But this issue is solved, indeed. Thank you very much!