franzenzenhofer/f19n-obtrusive-livetest

MVP finish

Closed this issue · 13 comments

franzenzenhofer commented

  • able to import rules

  • (ideally: choose a (single) folder (rules still enable / disable / view))

  • new: no pre-check of rules anymore

  • new import rules / custom rules add further down (de-emphasizing of this feature)

  • upload with same rule as existing one should update the old one

  • view button for custom rules

  • no longer able to edit rules in browser (no new rule button, no duplicate rules, no edit)

  • new default position: right top (and snapped if at top right position)

  • default rules that were deleted (after app update) should vanish

  • change name of the extension to "Obtrusive Live Test" (change name of repository to "f19n-obtrusive-live-test"

  • general bug fixes

franzenzenhofer commented

hi moritz, added one thing

the official name of this extension is "Obtrusive Live Test"

if the old name "Obtrusive Livetest Chrome Extension" shows up anywhere visible, please change.

neuling commented

Panel should now snap to the corners of the browser. It also snaps to the bottom of the browser. What do you think @franzenzenhofer? Does it feel right? Can be disabled easily, just wanted to show it to you.

71vjpbowa5

neuling commented

Most of the new view-only rule concept is finished. Possibility to select/upload multiple rules. No pre-check per rule. Removed functionality to edit and duplicate rules. Removed the ability to add an empty rule. Removed some unused packages.

Todo:

  • Beautify Rule-View (Highlight code, display rule name and add close button)
  • Move 'Add rule' down

yn314xmbxv

franzenzenhofer commented

ad Panel should now snap to the corners of the browser

mar-15-2017 10-41-55

works and snapping to top and bottom right side is cool

but: now there is a lot of stuttering (see attachment) when moving around, if (easily) possible see if there is away to reduce this stuttering.

franzenzenhofer commented

custom rules should also have the view button

  • 👍1
franzenzenhofer commented

otherwise looks good

franzenzenhofer commented

hmmm, adding rules with the same name should update the existing URL, not add another rule with the same name (this made sense when we had the editor in there, but with now just adding URLs it does not make sense any longer)

  • 👍1
neuling commented

i did some debugging about the stuttering. the iframe inside the panel causes some performance issues. without the iframe it works perfectly. not sure how to fix this atm will think about it.

neuling commented

removed the ace editor from the view-rule view and added syntax highlighting.

unspecified-3

  • ❤️1
neuling commented

add rule button is now underneath the "custom rule" section. what do you think @franzenzenhofer? for me, thats the most intuitive location for this button.

unspecified-4

  • ❤️1
franzenzenhofer commented

ad janking: not MVP critical, and yeah iframes are always an issue with rendering

neuling commented

unsupported rules should now be removed on install and/or extension update. to make sure the sync works also in production, we should test it once the extension is available on the chrome store.