frappe/frappe-ui

Typescript missing in production deployments

Closed this issue · 3 comments

When installed in production, non development environments, typescript is not included in the package.json; causing errors during build.

Error: [@vue/compiler-sfc] Failed to load TypeScript, which is required for resolving imported types. Please make sure "typescript" is installed as a project dependency.

/home/frappe/frappe-bench/apps/crm/node_modules/frappe-ui/src/components/Button.vue

The package file should have a typescript dependency as below:

"dependencies": {
"typescript": "^5.0.2"
},

I wonder if someone has put a bunch of dependencies in the dev portion of the package.json that should be in the production dependencies.

This needs to be fixed, affecting all of the down stream projects. Experienced with CRM and builder