frc604/FRC-2013

Draw up procedure for code contributions

Closed this issue · 4 comments

To control quality and monitor modifications to the code, I am considering implementing stricter policies for pushing code to the main repo.

Forks of private repos are themselves private, and don't count toward any sort of repository quota. As issues are created for various implementation details, they can be assigned to different people on the team. Actual modifications to the code can be conducted on separate forks and feature-branches, with pull requests submittrd back to the mainline once a component is completed. With the "hub" command-line tool, the original issues can even be converted directly into pull requests.

This way, we can divide up the workload more, and get more people actively involved, without sacrificing the maintainability of the project, as each piece of code is reviewed before the official merge is made.

If anyone is out there - thoughts?

I think that's a good idea, primarily because it makes bug assignment easier.
I'm all for it -- let's do it.

Depends on how many people are actually working on this. If there aren't too many people, then its not really necessary.

EDIT: shoot that was an accident
didn't mean to close it

I'm glad you guys are thinking of code review. I'll try and help out with bug triaging and code review.
:D

(I'm stupid and didn't read what Michael wrote. Ignore what I wrote earlier).

Since we're running with this now, I'll close off the issue.