Can't set DERP_STUN and DERP_VERIFY_CLIENTS to false

Question

Can't set DERP_STUN and DERP_VERIFY_CLIENTS to false

tzhao11 opened this issue 3 years ago · 4 comments

derper seems to parse boolean argument solely based on whether the corresponding command line flag exists or not, regardless of its value, so passing in --stun false or --verify-clients false has no effect. We might need to stop passing these flags to derper when DERP_STUN and DERP_VERIFY_CLIENTS are not set to true.

I can't think of a clean way to do this without introducing an entrypoint script. Any ideas?

Answer 1 · 2021-12-24T16:48:04.000Z

thanks for your report, let me take a look.

Answer 2 · 2021-12-24T17:03:03.000Z

it seems derper using the "flag" package, switching to "=" seems to be working.

https://github.com/tailscale/tailscale/blob/bc537adb1a6a9794f7e74337880cc63c915d19f9/cmd/derper/derper.go#L123

Answer 3 · 2021-12-24T17:06:12.000Z

@tzhao11 I updated the command in the main branch, could you help me double check whether it works as expected now?

Answer 4 · 2021-12-25T04:52:58.000Z

@fredliang44 working as expected now. Thanks for the fix!