freeciv/freeciv-web

CMA in Freeciv-web

andreasrosdal opened this issue · 11 comments

cazfi commented

What are you missing? I haven't tested server-side CMA much.

andreasrosdal commented

The server side changes in this needs to be cleaned up and included in the Freeciv C server:
Lexxie9952/fcw.org-server@caf342e#diff-084184354ca98a010578f7d996d79bfbca0509e9a889e1e69535bc65e2bf1d79

cazfi commented

That commit seems to be mostly about backporting server-side CMA + completely unrelated changes.

Some of those network protocol parts have been dropped from freeciv since, as nobody was using them. Maybe we need to put them back.

cazfi commented

First server side change -> https://osdn.net/projects/freeciv/ticket/45268

  • 👍1
andreasrosdal commented

Yes, Freeciv-web needs a server side CMA. It should be fast and have a very simple API in the normal network packets system. If you will please add server side CMA to the Freeciv C server, then I can implement in Freeciv-web.

cazfi commented

The latter part is coming in -> https://osdn.net/projects/freeciv/ticket/45485

Most probably I can implement it before the end of week.

  • 🎉1
andreasrosdal commented

Very nice! Also: www.fciv.net has been updated to the same version as freeciv/freeciv-web - so these are both compatible and running the latest Freeciv C server.

cazfi commented

The latter part is coming in -> https://osdn.net/projects/freeciv/ticket/45485

The difference in the implementation there compared to one you linked is that I went for separate packets for setting cm parameter and clearing it, to avoid sending some dummy parameter data when one is about to remove the parameter.

cazfi commented

Do you have anything on the web-client side to share (make a PR about)?

andreasrosdal commented

Here's a simple CMA for FCIV.NET
fciv-net/fciv-net@e2da9ce

This could be modified to be usable in Freeciv-web.

cazfi commented

Thanks. Started working on a port.