Support verifying that a leaf of type empty is present or not in ActionRequest.Input

Question

sebastien-guay opened this issue 2 years ago · 6 comments

Support verifying that a leaf of type empty is present or not in ActionRequest.Input.

Currently, calling req.Input.GetValue(...) will always return nil whatever the leaf is there or not.

Having something like req.Input.HasLeaf(name) would be nice.

Answer 1 · 2023-01-31T22:36:37.000Z

I created branch issue-21 with fix to checkout. GetValue() should return something now. GetValue() == val.NotEmpty in fact

Answer 2 · 2023-01-31T22:37:07.000Z

I'll merge this in few days if i do not hear from you otherwise that this doesn't work for you

Answer 3 · 2023-02-03T19:57:36.000Z

I'll merge this in few days if i do not hear from you otherwise that this doesn't work for you

I don't see the issue-21 branch but returning val.NotEmpty looks good.

Answer 4 · 2023-02-14T14:52:40.000Z

Is this issue has been resolved?

Answer 5 · 2023-02-14T14:55:31.000Z

yes, but i forgot to merge. should be in master now

On Tue, Feb 14, 2023 at 9:52 AM sguay ***@***.***> wrote: Hi @dhubler <https://github.com/dhubler>! Is this issue has been resolved? — Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACA7QM3UE2E7CAG4Q3T2TWXOL4FANCNFSM6AAAAAATZ4BXM4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Answer 6 · 2023-02-14T15:01:15.000Z

Thanks a lot!