Bug in support for RFC 8525

Question

Bug in support for RFC 8525

b-kamphorst opened this issue 7 months ago · 3 comments

Hi!

If I interpret the supported RFC 8525 correctly, the container modules-state from restconf/data/ietf-yang-library is deprecated in favor of a container yang-library. However, when I call the endpoint on the Car example, the reply contains modules-state but not yang-library. Is this a bug?

Answer 1 · 2024-04-17T16:46:05.000Z

i think this area has not received a lot of interop testing, so if you see something that looks off, it likely is.

…

On Wed, Apr 17, 2024 at 11:21 AM bart ***@***.***> wrote: Hi! If I interpret the supported <https://freeconf.org/docs/reference/compliance/rfcs/> RFC 8525 <https://datatracker.ietf.org/doc/html/rfc8525> correctly, the container modules-state from restconf/data/ietf-yang-library is deprecated in favor of a container yang-library. However, when I call the endpoint on the Car example, the reply contains modules-state but not yang-library. Is this a bug? — Reply to this email directly, view it on GitHub <#60>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACA7WTKVPG6ZZBSLZ5WILY52HQJAVCNFSM6AAAAABGLRMWCKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DQNJWGAZTKOI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Answer 2 · 2024-04-30T10:26:23.000Z

Thank you for the swift reply. I find an excuse to work on this (no guarantees), I could make a PR. Would you be open to that? From what I can see, this issue requires extending device/yang_lib_node.go and device/yang_lib_test.go. Would you agree?

Answer 3 · 2024-04-30T13:48:52.000Z

absolutely. Yes, those appear to be the right files.

…

On Tue, Apr 30, 2024 at 6:26 AM bart ***@***.***> wrote: Thank you for the swift reply. I find an excuse to work on this (no guarantees), I could make a PR. Would you be open to that? From what I can see, this issue requires extending device/yang_lib_node.go <https://github.com/freeconf/restconf/blob/master/device/yang_lib_node.go> and device/yang_lib_test.go <https://github.com/freeconf/restconf/blob/master/device/yang_lib_test.go>. Would you agree? — Reply to this email directly, view it on GitHub <#60 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACA7QCN4HAE6RII2OISY3Y75WWLAVCNFSM6AAAAABGLRMWCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUHEZTIMRTGY> . You are receiving this because you commented.Message ID: ***@***.***>