freedomofpress/sunder

Docs state that Node v4.7 and v5.1

Closed this issue · 1 comments

emkll commented

Bug

Description

Documentation sates that node v4.1 and v5.7 are tested for use with sunder. However, underlying dependency electron-rebuild (v.1.5.7) requires node>=6 (see https://github.com/electron/electron-rebuild/blob/v1.5.7/package.json#L28)

Steps to Reproduce

npm install on master branch with node 4.x or 5.x and observe the following error:

/Users/m/src/sunder/node_modules/electron-rebuild/lib/src/rebuild.js:73
                depKeys.push(...Object.keys(rootPackageJson.dependencies || {}));
                             ^^^

SyntaxError: Unexpected token ...
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Users/m/src/sunder/node_modules/electron-rebuild/lib/src/main.js:3:19)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)

Expected Behavior

Application should install

Actual Behavior

An error occurs (see above)

emkll commented

Closed as duplicate of #66.