Slick Enumerators
Closed this issue · 27 comments
Hi all,
Just found this project, it aims to allow to transform slick queries into Play Enumerators to be able to stream chunked results (using Websocket, Comet, SSE...)
https://github.com/youdevise/scalaquery-play-iteratees
Do you think it would be interesting enough to integrate this into play-slick plugin ?
Have a nice end of year,
Loïc
Yep! I am talking to Mark (the owner today) to discuss how to integrate it! :)
Great news!
Le 8 janv. 2014 15:14, "Fredrik Ekholdt" notifications@github.com a écrit
:
Yep! I am talking to Mark (the owner today) to discuss how to integrate
it! :)—
Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-31833977
.
So Marc Siegel, the owner has agreed to help us out, and we have working plan to move it into play-slick.
You are welcome to check it out!
https://docs.google.com/document/d/1ohHTiq6tyNb3Q3P7Sda5YG3rD2J2n0WpJqoL7XBXLAc/edit?usp=sharing
Progress: I am porting scalaquery-play-iteratees to Slick 2.0.x first, that work is in progress
Alright sounds good! Thanks for letting us know :)
@freekh Ok, just finished porting scalaquery-play-iteratees to Slick 2.0.0. Tomorrow I will do a release of that, and then I will begin porting into play-slick
Awesome stuff! Sounds good 👍
Yep, I think that is right.
F
Marc notifications@github.com wrote:
@freekh I'm still planning to base off of branch slick20, is that
right?
Reply to this email directly or view it on GitHub:
#115 (comment)
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Any news Marc? Master /slick20 branch is now operational...
Hi Fredrik,
I'm scheduled to spend some time on this this week. Thanks for getting it operational, I'll rebase on that and let you know how it goes.
-Marc
From: Fredrik Ekholdt [notifications@github.com]
Sent: Monday, February 03, 2014 12:23 PM
To: freekh/play-slick
Cc: Marc Siegel
Subject: Re: [play-slick] Slick Enumerators (#115)
Any news Marc? Master /slick20 branch is now operational...
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-33977646.
Great - just wanted to let you know :)
On February 3, 2014 7:32:26 PM CET, Marc notifications@github.com wrote:
Hi Fredrik,
I'm scheduled to spend some time on this this week. Thanks for getting
it operational, I'll rebase on that and let you know how it goes.-Marc
From: Fredrik Ekholdt [notifications@github.com]
Sent: Monday, February 03, 2014 12:23 PM
To: freekh/play-slick
Cc: Marc Siegel
Subject: Re: [play-slick] Slick Enumerators (#115)Any news Marc? Master /slick20 branch is now operational...
—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/115#issuecomment-33977646.
Reply to this email directly or view it on GitHub:
#115 (comment)
Sent from my Android device with K-9 Mail. Please excuse my brevity.
@freekh just to be clear -- I'm still working off of branch play20, right? Not play20-rcX?
You vän work off the master branch now. It was merged with the play20 branch
Ah! Ok, will rebase again.
-Marc
From: Fredrik Ekholdt [notifications@github.com]
Sent: Monday, February 10, 2014 11:28 AM
To: freekh/play-slick
Cc: Marc Siegel
Subject: Re: [play-slick] Slick Enumerators (#115)
You vän work off the master branch now. It was merged with the play20 branch
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-34650984.
Ouch sorry about that. I should have mentioned it :/ It shouldn't be too much merging that needs to be done though (I hope)
On February 10, 2014 5:40:49 PM CET, Marc notifications@github.com wrote:
Ah! Ok, will rebase again.
-Marc
From: Fredrik Ekholdt [notifications@github.com]
Sent: Monday, February 10, 2014 11:28 AM
To: freekh/play-slick
Cc: Marc Siegel
Subject: Re: [play-slick] Slick Enumerators (#115)You vän work off the master branch now. It was merged with the play20
branch—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/115#issuecomment-34650984.
Reply to this email directly or view it on GitHub:
#115 (comment)
Sent from my Android device with K-9 Mail. Please excuse my brevity.
No no, it's fine, don't worry :)
Please remember to update README.md to reflect the state of master now:
- What are the features it has?
- Examples for each
- Slick version is 2.0.x
- Building 0.6.0-SNAPSHOT for Play 2.2x + Slick 2.0.x -- see 0.5.x for previous
- Copyright 2013-2014
-Marc
From: Fredrik Ekholdt [notifications@github.com]
Sent: Monday, February 10, 2014 11:55 AM
To: freekh/play-slick
Cc: Marc Siegel
Subject: Re: [play-slick] Slick Enumerators (#115)
Ouch sorry about that. I should have mentioned it :/ It shouldn't be too much merging that needs to be done though (I hope)
On February 10, 2014 5:40:49 PM CET, Marc notifications@github.com wrote:
Ah! Ok, will rebase again.
-Marc
From: Fredrik Ekholdt [notifications@github.com]
Sent: Monday, February 10, 2014 11:28 AM
To: freekh/play-slick
Cc: Marc Siegel
Subject: Re: [play-slick] Slick Enumerators (#115)You vän work off the master branch now. It was merged with the play20
branch—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/115#issuecomment-34650984.
Reply to this email directly or view it on GitHub:
#115 (comment)
Sent from my Android device with K-9 Mail. Please excuse my brevity.
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-34654109.
Yep, will do! Thanks for the heads up.
There, I think it looks good now?
Yup! Looks good.
-Marc
From: Fredrik Ekholdt [notifications@github.com]
Sent: Monday, February 10, 2014 12:38 PM
To: freekh/play-slick
Cc: Marc Siegel
Subject: Re: [play-slick] Slick Enumerators (#115)
There, I think it looks good now?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-34658956.
Hi @freekh, you can see my progress on merging in here: https://github.com/youdevise/play-slick/commits/port-scalaquery-play-iteratees-rebase-3
I've got about half of the module tests merged and passing, slightly slowed down by needing to port back to specs2.
I think I'll have the basic proposed port done by the end of this week...
Bah, I'll finish this next week...
OK, it is looking good! :)
On February 13, 2014 8:47:04 PM CET, Marc notifications@github.com wrote:
Bah, I'll finish this next week...
Reply to this email directly or view it on GitHub:
#115 (comment)
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Ok, initial PR is submitted. We still need to decide on a way to run the integration tests of the sample app from the Travis CI build -- do you prefer doing it via .travis.yml, as I did in scalaquery-play-iteratees, or doing it via the main build.sbt file?
Awesome stuff Marc! I am busy this weekebd but i will have a look on Tuesda - hope that is OK...
About the build I am not sure, but it might be better to do it through SBT if people want to build and verify the build for themselves? I am open for both though... It is good that you fix this (one way or the other) because it is really annoying to not be able to accept minor PRs without checking out etc etc for my self...
Sure Frederik, let me know!
Merged