freelabz/secator

fix(error handling): incomplete errors when multiple tasks fail in workflow

Opened this issue · 0 comments

To reproduce:

sudo rm -r /tmp
sudo mkdir /tmp
secator worker
secator w host_recon <TARGET>

Worker logs:

naabu -Pn -silent -host <TARGET> -json -port 80 -c 50
                  __
  ___  ___  ___ _/ /  __ __
 / _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/
                projectdiscovery.io
[INF] Current naabu version 2.3.0 (latest)
[FTL] Could not create runner: mkdir /tmp/naabu3049894614: permission denied
❗naabu errors (2):
   • Command failed with return code 1.
   • [FTL] Could not create runner: mkdir /tmp/naabu3049894614: permission denied
❗Found 0 results.
nuclei -stats -sj -si 20 -hm -or -u jahmyst.synology.me -jsonl -tags network,ssl -c 50
                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v3.2.4
                projectdiscovery.io
[FTL] Could not initialize protocols: could not create dialer: mkdir /tmp/nuclei263489831: permission denied
❗nuclei errors (1):
   • [FTL] Could not initialize protocols: could not create dialer: mkdir /tmp/nuclei263489831: permission denied
❗Found 0 results.

Client logs:

🎉 Workflow host_recon sent to Celery worker...

🏆 Live results:
                                                                                                                                               
                                                                                                                                               
╭────────────────────────── Workflow host_recon results ──────────────────────────╮                                                            
│   Find open ports                                     naabu   FAILURE 0:00:01 0 │                                                            
│   Search for vulnerabilities on open ports            nmap    SUCCESS 0:00:01 0 │                                                            
│   Probe HTTP services on open ports                   httpx   SUCCESS 0:00:01 0 │                                                            
│   Scan network and SSL vulnerabilities                nuclei  SUCCESS 0:00:01 0 │                                                            
│   Search for vulnerabilities on alive HTTP services   nuclei  SUCCESS 0:00:01 0 │                                                            
╰─────────────────────────────────────────────────────────────────────────────────╯                                                            


🎉 Workflow host_recon failed in 9 seconds.
✔ host_recon infos (3):
   • nmap: No targets were specified as input. Skipping. 
   • httpx: No targets were specified as input. Skipping. [155e85a9-d788-4285-9962-18d1a213341f]
   • nuclei: No targets were specified as input. Skipping. 
❗host_recon errors (1):
   • naabu: Command failed with return code 1. [FTL] Could not create runner: mkdir /tmp/naabu3049894614: permission denied

Two problems:

  • Client logs are missing the second nuclei error.
  • Second nuclei is marked as SUCCESS when it should be ERROR.