freeswitch/spandsp

Reason for removing FSK_FRAME_MODE_8N1_FRAMES?

InterLinked1 opened this issue · 3 comments

This is more of an information request than a bug, per se.

In this commit from 2012, FSK_FRAME_MODE_8N1_FRAMES was removed:
4265af6#diff-f39a1bf3eb4f90837f55490c3be3d02e605bb22dde779084f0d5f45a8dfc5970

FSK_FRAME_MODE_7E1_FRAMES has the same value as this (10), but semantically it means something very different.

What is the replacement for this macro? Not sure I follow this change, given that 8N1 is the most common modem setting, and the remaining settings are quite obscure. I am trying to fix code that doesn't compile because it uses the removed FSK_FRAME_MODE_8N1_FRAMES macro, and it isn't clear what the replacement should be, since 8N1 is simply gone.