V.17 fixed point issues
lexxer3d opened this issue · 3 comments
lexxer3d commented
Hi!
I've found the following issues while testing V.17 14400 TCF with fax_decode tool when compiled with fixed point support:
- v17rx.c is missing SPANDSP_USE_FIXED_POINTx
- int32 overflow happens for s->training_error, long training threshold (line 961) and training succeeded threshold (line 1139).
Suggested fix with TCF sample is attached.
v17_fixedp.zip
coppice-git commented
I have commited this change. I haven't really been keeping the fixed point stuff up to date, as nobody seemed to care about it. May I ask what platform you are using the fixed point code on? Do you have problems with the other modems? The last time I remember looking at the fixed point stuff I thought there were still multiple scaling issues in the modems.
lexxer3d commented
It's armv7l. Btw, even with the fix it doesn't work fine, so I switched to float point.
Tried two different modems.