`includeGlobs` is not supported
ryankashi opened this issue · 3 comments
Hi there! I am using your polyfill to register my content script via:
var content_script_registration_dict = {
"matches":["*://*.twitch.tv/*"],
"includeGlobs":['*player.twitch.tv*'],
"js":[{file:"my_javascript.js"}],
"css":[{file:"my_css.css"}]
}
chrome.contentScripts.register(content_script_registration_dict);
However I am noticing that my includeGlobs segment is being ignored. Instead, it ignores the includeGlobs match pattern, and injects my_javascript.js into all pages under matches
regardless of whether it matches includeGlobs
or not.
When I instead place my JavaScript code inside the manifest.json file, everything works as expected, thus it appears to be an issue with this package.
I think that this is an important fix for this package since includeGlobs is currently not behaving as expected.
Thanks!
Update, it appears that the excludeMatches pattern as well excludeGlobs are not working either
Yes, you can see which properties are supported here:
content-scripts-register-polyfill/ponyfill.ts
Lines 89 to 92 in 0263492
PR welcome to add what's missing