freiksenet/react-kinetic

Don't use synchronous require

Closed this issue · 1 comments

In your code you use require, for example:

var ReactKinetic = require('./src/ReactKinetic');

This is synchronous code, which is very bad for performance and is discouraged to use in production code.

Please use an asynchronous loader like requirejs.

http://requirejs.org/

react-kinetic is using CommonJS, not AMD modules. I am not aware of any performance problems from using CommonJS require this way. This is how they do it in, for example, React.