frend/frend.co

Add Firefox transitionEnd event or replace with timeout parameter

thomasdigby opened this issue · 1 comments

The transitionEnd event isn't being bound on Firefox as we're checking for a transform property to be transitioned, which is prefixed as MozTransform on Firefox. We could add in a detection for prefixed CSS3 properties, but it seems to be adding a bit of effort/complexity for not much value.

On top of that, detecting the transitionEnd event on the panel if it has a transform property seems pretty assumptious, it could have any transition really, visibility, opacity, position etc.

I reckon we should do away with this altogether and replace it with a timeout parameter, we could simplify the code and pretty much guarantee it will fire in supported browsers, although it would mean a hard-coded value required on initialisation and detecting that automatically might be the best for the developer enabling them to drop in the component without much set-up.

Thoughts?

Not necessary if visibility is transitioned matching the transform. Removed completely from component.