Cumulative Profit Chart is broken
wassertim opened this issue · 1 comments
FreqUI Version
- Version of freqUI: latest
- version of freqtrade: NA
Describe the bug
As a user of frequi, I recently noticed, that the cumulative profit chart has gone broken. When you select a bot, it does not change and behaves strangely, not showing the actual performance of a selected bot.
I also found the cause. The last commit to the CumProfitChart is changing some typings and also property names from noMerge to notMerge. And that seems is breaking the feature.
chart.value?.setOption(chartOptionsLoc, { notMerge: true });
Here is the link to the commit:
304e0ac
To Reproduce
Steps to reproduce the behavior:
- checkout main branch
- run it locally with your trading bots
- select one of your bots
- See the cumulative chart
Expected behavior
The cumulative chart should show a performance of a bot after selecting it.
Desktop (please complete the following information):
- OS: NA
- Browser every browser
- Version NA
Smartphone (please complete the following information):
- Device: NA
- OS: NA
- Browser NA
- Version NA
Additional context
By reverting that commit, the issue can be fixed quickly. Should I create a PR?
Well the fun part is - the "noMerge" property was a spelling mistake (ported from other charts) - and never had any actual impact (as far as i could find, noMerge
never existed on echarts).
Removing that line will be fine (see linked commit) - reverting the whole commit is not - as this does now provide some additional type-safety - allowing typescript to catch such mistakes (like - spelling mistakes).