`make` support
twe4ked opened this issue · 7 comments
I think we've discussed this before, @jasoncodes, but I can't remember the outcome.
Could we have a --make option that cd's into the directory and runs make during the build?
# this would cd into the `~/.fresh/source/martanne` directory, run make,
# and link the resulting `vis` file to the bin directory.
fresh martanne/vis vis --make --binIt could also take an argument that could be run in place of the --make command.
--make="make install".
I like the idea of supporting makefiles because they should run fast when there’s nothing to do. I wonder if we should go for something more generic though rather than --make? Something like --pre=make. I’m quite happy with --make though.
I don't mind --pre either. Perhaps --make could be a shortcut for --pre=make and --make=foo could be a shortcut for --pre=foo.
I’d rather just have one or the other. --make is fine.
I kind of like the idea of having both. It's only a few extra lines in _parse_fresh_dsl_args.
Edit: It could be an undocumented feature too.
It seems like diff-highlight now requires compilation. git/git@0c977db
Workaround is to --ref to the commit before this change or to do the ~~~compilation~~~ concatenation with multiple fresh calls. Note that a shebang needs to be added using --filter.
Hi guys, is this ready for use yet? I'm looking to pull down sources and compile them locally, and this looks like what I'm after!
Hi Iain. We are in the middle of a major refactor so have not completed this new feature yet. You could certainly check out the work in progress branch on #131 locally (run git checkout pre in ~/.fresh/source/freshshell/fresh) and give it a whirl though. We’d love your feedback.