friedPotat0/Spam-Scores

Popup and settings don't consider themes

henkelmax opened this issue · 7 comments

The spam score popup and the settings screen don't consider the theme.

image
image

It looks like the white background colour is set outside of the shadow root containing the add-on settings.

One workaround could be to implement a dark mode specifically for this add-on. But I don't know if there are multiple dark theme colour variants to consider when implementing such a feature.

I will look into this in more detail soon.

I'm using the dark theme and the popup is unreadable for me:

grafik

Are you using any specific dark theme or the one from Mozilla? I've tested the official dark mode theme of Mozilla and it looks like in the screenshot of @henkelmax.

Sadly I have still not figured out how to adjust the layout of the popup and the settings pane according to the selected dark or light theme. Any ideas or hints on how to make this possible for Thunderbird's MailExtensions are appreciated.

I'm using Windows 10 in dark mode and the default thunderbird theme:

grafik

Additionally, I've Dark Reader installed but I don't think it influences the UI/chrome (and the popup doesn't change when I disable Dark Reader).

I think I've changed some colors in the settings a bit (not sure what the defaults are anymore, and it was before using Dark Reader which changes them too, I think):

grafik


Sadly I have still not figured out how to adjust the layout of the popup and the settings pane according to the selected dark or light theme. Any ideas or hints on how to make this possible for Thunderbird's MailExtensions are appreciated.

I'm sorry, I have absolutely no experience in developing Thunderbird addons :/

Ok, thanks for the information. It seems like the overridden text color has caused the font in the popup to be displayed like that. I've set the font color to black as long as I've not managed to figure out how to properly consider dark themes in general.

The fix will be included in the next update which I'm going to publish in the next couple of days.

The dark mode will be fully supported in the next add-on version. (fixed in 7adf103)