Spam score column not longer available in Thunderbird 115
Closed this issue · 24 comments
Describe the bug
Spam score column not longer available in Thunderbird 115. There were GUI changes in Thunderbird 115. I guess it broke the column feature. The button in the message area still works fine.
Reproduction steps
Right click the column headers and the spam score option is no longer available
Expected behavior
The spam score column should be available
Thunderbird (please complete the following information):
- Windows 11
Spam Score add-on (please complete the following information):
- Version: 1.4.1
I can confirm this here on TB 115.0.1 (64-bit) from EndeavourOS Linux 6.4.4-zen1-1-zen
Thank you for reporting the problem. Since I also use Thunderbird 115 myself, I will take a look at the problem in the next few weeks. Unfortunately, I don't have much time for the project at the moment.
Did some reading: It is not possible to add custom columns to the new treeview in Thunderbird 115.
Bug report: No way for extensions to add columns to the new tree list widgets
Work is started on an API to reenable it:
WIP: Bug 1817682 - Functions for extensions to add custom column handlers.
I can confirm it's no longer working on Thunderbird 115.3.1 (64-bit) on macOS 13.6
The last last few Thunderbird updates were half-arsed themselves, so please don't feel bad that your add-on no longer works.
Hi @friedPotat0 .
thx a lot for your great plugin. I looove it 🥇
Sadly TB forced their update to 115.x now. Any idea when you may be able to update SpamScores?
Elsewise I'll downgrade to the previous version, I guess.
Thanks for the compliment.
I have done some research and have not yet found a solution to make the add-on fully functional in the new TB version. I find this very unfortunate as I originally created the add-on for myself and used it every day.
It seems that other add-ons have also disabled the column feature. So I guess there is not much I can do at the moment. But if anyone has any ideas on how to get the column working again, please let me know.
You're welcome, and yes sad indeed. Will go back to 102 until the change @digitaldutch mentioned will be inocorporated. Does anybody know where I can leave a comment to help press the urge vor implementation?
TB-team is movin' forward I think. According to this https://bugzilla.mozilla.org/show_bug.cgi?id=1615801 they re-implement the column-api for beta-testing on Feb 19th?
Been a long time, and I just took another look on the state of affairs. As far as I understand it final re-implementation of the API is postponed after TB128, but experimental use is ongoing. @friedPotat0 any way you may join the train?
Thanks for this plugin, even without the column it is still very useful on TB115.
It would be great if the manifest allowed installation anyways even if the column doesn't work... (did this manually for my personal installation, but its not feasible to recommend this to others...)
We'd like to do some work on the column re-implementation but with the experimental API i'm unsure if its worth while to put in the work now...
even without the column it is still very useful on TB115.
Indeed …
It would be great if the manifest allowed installation anyways even if the column doesn't work... (did this manually for my personal installation, but its not feasible to recommend this to others...)
I would be more than happy if you could share a how-to … or a fork witout the column implementation?
.xpi is just a zip file. Extract manifest.json, edit strict_max_version to 115.*, update the file in the zip archive (or repack) and (re-)install.
I just created an alpha branch in my fork of the plugin which contains my pull requests #62 and #61 and the required changes to manifest.json
If you build the plugin from https://github.com/vali-um/Spam-Scores/tree/alpha you get a plugin version 1.4.2-alpha1 you can install
Unfortunately nomatter what I try, I can neither change the manifest of the official .xpi nor can I create a xpi of @vali-um's version, which is accepted by my thunderbird … either thunderbird tells me the file is corrupt or not compatible with 115.1.1 …
It would be great if I could set the strict_max_version to * in general. Unfortunately the Thunderbird add-on store always throws an error saying that the version should match a proper version string.
Your add-on failed validation with 1 error.
"/applications/gecko/strict_max_version" must match pattern "^[0-9]{1,3}(\.[a-z0-9*]+)+$"
If I omit the strict_max_version completely from the manifest.json as it is documented in the Web Extensions docs (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings), it complains that the strict_max_version is required.
Your add-on failed validation with 1 error.
A "strict_max_version" is required for Thunderbird Mail Experiments, including Theme Experiments
So all I can do for now is set the version to 115.* and wait for the next version not to be included 😞.
Thanks for v1.4.2!
No column yet, but a big step in the right direction!
@friedPotat0 Thanks for the release, didn't know that the addon store requires this flag.
Are you planning to work on the column feature with the experimental interface on TB115 or TB128?
We are thinking about putting in some work but i wouldn't want to work on something you already have prepared.
At the moment I don't have the time to test any experimental interface and I have not implemented anything so far. But of course I would be extremely happy if you could invest more of your time in the project.
Please let me know if you need any help or additional information.
The Thunderbird Team recommended the following example add-ons that already use the new custom column API: https://thunderbird.topicbox.com/groups/addons/Tf7f2d663f8314b02-M331579b0c86d57b4d9d95b41/proposal-custom-column-api-for-message-list
Thank you so much for your help! Everything worked perfectly during my review. 💯🎉 And I like the idea to split the column into two columns. One with the icon only and one with the score 👍
The new version v1.5.0, including this change, is now available in the Thunderbird add-on store and on the releases page (https://github.com/friedPotat0/Spam-Scores/releases/tag/1.5.0).
Thx a lot for the good work! Much appreciated. Have a great weekend! 👋 🍻
FYI after updating to TB 128 the plugin still works