Expensive use of findall/3

[pmoura]

The following goal is costly and a bad programming idiom:

cplint/prolog/viterbi.pl

Line 56 in 5fa2d56

findall(_,find_exp(GL,M),_),

This is reported by the Logtalk linter (git version) as:

*     Suspicious call: findall(A,find_exp(B,C),D) instead of find_exp(B,C),fail;true
*       while compiling object viterbi
*       in file /Users/pmoura/Downloads/cplint-master/prolog/viterbi.pl between lines 48-62

As suggested in the warning message, using instead a (find_exp(B,C),fail;true) goal is both clear and faster.

[friguzzi]

Thanks, fixed in 242814b

[pmoura]

That was fast! 🙂