Column count fetching not always reliable
Closed this issue · 7 comments
I can't reproduce this consistently but I was made aware of the current method of fetching the column count not always being reliable.
is there a way to get this to work with 5k,6k or 7k maps? or is it just for 4k maps?
It used to work for 4-9k but it looks like something broke column count reading for good on recent releases. If you really want to play on non-4k maps try v1.0.0-rc11 (note that the interface/functionality is different -- check maniac -h!), it worked for me just now.
This issue has been left open for too long anyways, I'll look into it.
im using the v1.0.0-rc11debug but it only recognizes it as either 3 column or 4 column , never more than that
Strangely, I can't reproduce this error with local builds -- but I can with remotely built ones, i.e. those you see in the Releases tab.
@gonsodany Could you try it with this build?
Edit: Just tried again, remotely built rc12 now works again. I guess this is the column count reading inconsistency I was warned of. I'll re-implement it in a memory independent way, could take a little while.
Action parsing now takes roughly twice as much time as it used to but the column count should now always be accurate. Please note that this will break on maps that don't use the last column at all (although I doubt such maps exist).
I'd really appreciate if you could take a look at this and see if it works for you, builds with this bugfix can be downloaded in the Actions tab under the 'Artifacts' header.
No response yet but it still works for me and nobody is complaining yet, closing.
yes, it works with the one you send me