rotate, scale, and nonuniform_scale methods for Mat4

Question

rotate, scale, and nonuniform_scale methods for Mat4

Closed this issue 5 years ago · 2 comments

As Mat4 (and Wat4) already have translate and translated methods, it would make sense for it to also have rotate, rotated, scale, scaled, nonuniform_scale, and nonuniform_scaled methods.

Answer 1 · 2020-02-07T00:47:04.000Z

Never mind. I just found Isometry3 and Similarity3. Sorry.

Answer 2 · 2020-02-07T02:02:21.000Z

I've been debating this because, on the one hand, Mat4s are generally used as homogeneous 3d matrices, and you could add these methods with that assumption. On the other, these ops also all have parallels in 4d, and are inherently 3d operations. So they currently exist on Mat3 and you can then do into_homogeneous() to turn it into a homogeneous Mat4. Should be just as fast after the optimizer.