fullcalendar/fullcalendar-workspace

Update FullCalendar to v3.10.0 in composer.json

nlyn opened this issue · 8 comments

nlyn commented

It looks like Scheduler is still installing v3.9.0 even though v3.10.0 is out now.

acerix commented

How are you installing it?

nlyn commented

I have these 3 dependencies in my package.json:

    "fullcalendar": "^3.10.0",
    "fullcalendar-reactwrapper-with-scheduler": "^1.1.0",
    "fullcalendar-scheduler": "^1.9.4",

It seems that fullcalendar-scheduler will always install 3.9.0 in its own node modules.

nlyn commented

I should note that the problem I'm trying to resolve is, since upgrading fullcalendar to v3.10.0 I'm experiencing this kind of problem fullcalendar/fullcalendar#3911 which seems to be a regular thing when people upgrade fullcalendar with scheduler also enabled.

I'm wondering if perhaps making sure scheduler has a dependency for the most up to date fullcalendar, it might resolve the problem.

acerix commented

Thanks for the details, I didn't notice that in composer.json

lucagouty commented

@acerix any news about that one ? It's impossible to update to 3.10.0 until that's fixed.

Also it's not the first time, it happened with previous release : fullcalendar/fullcalendar#4089 (comment)

Maybe we should think about a way to avoid this to happen again

I think what @arshaw did to fix that is updating all those :

  • composer.json
  • package.json
  • bower.json

You can see full scheduler 1.9.4 release here : efb6535...6ebc6d1

EDIT : For those like me using recent NPM version, the trick is to first install 3.10.0 and then edit package-lock.json with :

"fullcalendar": {
  ...
},
"fullcalendar-scheduler": {
  ...
  "requires": {
    "jquery": "2 - 3",
    "moment": "^2.20.1"
  },
  "dependencies": {
    "fullcalendar": {
      "version": "3.10.0",
      "resolved": "https://registry.npmjs.org/fullcalendar/-/fullcalendar-3.10.0.tgz",
      "integrity": "[copy from fullcalendar just above]"
    }
  }
},

Then rm -rf node_modules ; npm install and you're all good 🚀

It also made me realise we need to move jquery and moment to peerDependencies for scheduler (nice idea btw, it makes things way easier for us!)

  • 👍1
acerix commented

There's another issue regarding whether to update composer or drop support:

fullcalendar/fullcalendar#4489

arshaw commented

we decided to stop supporting composer for v4, so I'll close this issue