funcool/cuerdas

numeric? returns vector of matched regex(es), not a boolean

tuddman opened this issue · 2 comments

ref: https://github.com/funcool/cuerdas/blob/master/src/cuerdas/core.cljc#L215

convention of fnName? is to return true | false

docs say: Checks if a string contains only numeric characters.

numeric? instead returns vector of regex matches.

also, doesn't currently handle commas , or currencies, e.g. $

Thanks! I will fix it ASAP. (right now i'm not available because of my weeding days).

Fixed in 1.0.2