funcool/cuerdas

(starts-with? "" "xxx") returns true

AndyCorlin opened this issue · 7 comments

AndyCorlin commented

I found that:
(starts-with? "" "xxx") and (end-with? "" "xxx") both return true.

This was changed in "Minor code refactor", before that they returned false.
4ff5b32

Was the change intentional or is this a bug?

niwinz commented

looks like a bug

  • 👍1
AndyCorlin commented

Thanks for confirming!

So how do we go about it, will you fix it or do you want me to make a pull request?

niwinz commented

An PR is welcome, if not, I will find some time to fix this, looks a regression.

AndyCorlin commented

Thanks for merging the PR! When do you plan the next release? /Anders

AndyCorlin commented

Hi @niwinz! When do you plan the next release? /Anders

niwinz commented

Released a version in clojars ;)

AndyCorlin commented

Super, thanks, downloaded and it works!

Now I see it was released already the 14th, while I was monitoring the tags in GitHub where the release haven't yet appeared.