funkensturm/ember-local-storage

PeerDependency `@ember/string` is missing

Opened this issue · 0 comments

The addon is using @ember/string but its not declared as peerDependency.

This makes impossible to use @ember/string v4 as its a v2 addon

import { assert } from '@ember/debug';
import EmberObject, { computed, get } from '@ember/object';
import { getOwner } from '@ember/application';
import { dasherize } from '@ember/string';
const storage = {};
function tryStorage(name) {

There are two options to fix this issue:

  • adding dasherize as internal function (not braking - recommended)
  • adding @ember/string as peerDependency (braking)