Cachebust consider <script> tag without src attribute and failed
Closed this issue · 6 comments
Hi !
I have a problem with the current version of cachebust.
I'm working with davinkevin which sent to you a message earlier : #1
Actually the problem is : if a script tag is inside our base file and this tag don't contain src attribute : cachebust failed unfortunately ;(
--> at line 50 "scripts[j].attribs.src.split("?")[0];" because src is undefined
I prepared a push request for you ;)
Let me know if you can published this fix as soon as possible ?!
Thanks for your time !
Hey @spywen thanks for creating the ticket request. A project that I was working on encountered an issue because of this. Hopefully your fix will be put in.
Yep as soon as I'm back from a holiday and have a laptop!
On Sun, 1 Nov 2015 at 16:49, Tyrone Brim notifications@github.com wrote:
Hey @spywen https://github.com/spywen thanks for creating the ticket
request. A project that I was working on encountered an issue because of
this. Hopefully your fix will be put in.—
Reply to this email directly or view it on GitHub
#6 (comment).
Np ;) thanks ;) Enjoy the rest of your holiday !!!
:) thanks. And thanks for the contributions everyone, this is making me get
back into this kind of work - I'll have more free time soon so will be able
to maintain projects more. I've been lacking over the last 6 months!!
On Sun, 1 Nov 2015 at 17:04, Laurent Babin notifications@github.com wrote:
Np ;) thanks ;) Enjoy the rest of your holiday !!!
—
Reply to this email directly or view it on GitHub
#6 (comment).
Could you confirm #8 fix this issue ?